Run the devcontainer in its own container - #3105
Closed
dfabulich wants to merge 2 commits into
Closed
Conversation
`init-dev-docker` ran `make dist && ./listmonk --install`, and was an explicit manual step that users would have to do to get the `dev-docker` environment up and running. For users of the `dev-docker` development environment, this commit simplifies setup; users just have to `make dev-docker` without having to remember to `make init-dev-docker`. But, more importantly, this fixes the broken `devcontainer.json`, which gave users no opportunity to `init-dev-docker` before it automatically tries to start the `backend` container. Now, `backend` depends on a new `init` container, which runs `make init-docker` and exits. `make init-docker` runs `make build-frontend` (we never needed a production `make dist` build for development), builds `listmonk`, and runs `./listmonk --install --idempotent`. On my machine, this imperceptibly slows down `dev-docker` startup, running `./listmonk --install --idempotent` before starting the `backend`. Fixes knadh#3101
Contributor
Author
|
Merging this into #3102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is stacked on top of #3103.