Skip to content

Run the devcontainer in its own container - #3105

Closed
dfabulich wants to merge 2 commits into
knadh:masterfrom
dfabulich:devcontainer-own-container
Closed

Run the devcontainer in its own container#3105
dfabulich wants to merge 2 commits into
knadh:masterfrom
dfabulich:devcontainer-own-container

Conversation

@dfabulich

Copy link
Copy Markdown
Contributor

`init-dev-docker` ran `make dist && ./listmonk --install`, and was an explicit manual step that users would have to do to get the `dev-docker` environment up and running.

For users of the `dev-docker` development environment, this commit simplifies setup; users just have to `make dev-docker` without having to remember to `make init-dev-docker`.

But, more importantly, this fixes the broken `devcontainer.json`, which gave users no opportunity to `init-dev-docker` before it automatically tries to start the `backend` container.

Now, `backend` depends on a new `init` container, which runs `make init-docker` and exits. `make init-docker` runs `make build-frontend` (we never needed a production `make dist` build for development), builds `listmonk`, and runs `./listmonk --install --idempotent`.

On my machine, this imperceptibly slows down `dev-docker` startup, running `./listmonk --install --idempotent` before starting the `backend`.

Fixes knadh#3101
@dfabulich

Copy link
Copy Markdown
Contributor Author

Merging this into #3102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restarting the backend in the devcontainer restarts the devcontainer

1 participant